MHV-66099 Images page (image download, image layout and format, download alerts) #34706
+71
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoyer-va
requested changes
Feb 18, 2025
Comment on lines
32
to
36
| {`Showing ${paginatedImages[currentPage - 1][0].index} | ||
| to ${paginatedImages[currentPage - 1][0].index + | ||
| (paginatedImages[currentPage - 1].length - 1)} of ${ | ||
| imageList.length | ||
| } records from newest to oldest`} |
There was a problem hiding this comment.
Images aren't shown newest to oldest. Here's the correct wording from the ticket:
There was a problem hiding this comment.
Thanks for pointing out this oversight.
| > | ||
| Check your device’s downloads location for your file. | ||
| </va-banner> | ||
| <br /> |
There was a problem hiding this comment.
Don't use <br /> tags. Instead you can use the VA Design System margin tags, or move the alert banner outside of the <p> tags.
| @@ -41,7 +41,7 @@ const RadiologyImagesList = ({ isTesting }) => { | |||
| isTesting || false, | |||
| ); | |||
| const [isStudyJobsLoaded, setStudyJobsLoaded] = useState(isTesting || false); | |||
|
|
|||
| const [diacomDownload, setDiacomDownload] = useState(false); | |||
There was a problem hiding this comment.
The file is called is "dicom" as opposed to "diacom". Can you correct all the instances?
…ormat_and_download_alerts' of https://github.com/department-of-veterans-affairs/vets-website into MHV-66099_images_page_image_download_,_image_layout_,_format_and_download_alerts
mmoyer-va
requested changes
Feb 19, 2025
| @@ -382,12 +382,27 @@ ${record.results}`; | |||
| data-dd-privacy="mask" | |||
| data-dd-action-name="[lab and tests - radiology name]" | |||
| > | |||
| {record.name} | |||
There was a problem hiding this comment.
The new <HeaderSection> component has the header text in the header attribute. You shouldn't need it here any longer. Double-check this in a browser.
mmoyer-va
approved these changes
Feb 19, 2025
Wyzardsleeves
deleted the
MHV-66099_images_page_image_download_,_image_layout_,_format_and_download_alerts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated content regarding the Image Page.
This is not a bug.
Updated the JSX and already existing functions.
MHV Medical Records.
Related issue(s)
MHV-66099 Images page (image download, image layout and format, download alerts)
Screenshot
Testing done
What areas of the site does it impact?
MHV Medical Records